Fix prev/next navigation on section landing pages#85
Merged
Conversation
Section landing pages (parent: '/') are not sequential content, but prev/next treated all top-level pages as siblings. This caused /about/ to show Publishing Events and Calendar Spam as neighbors. Skip prev/next for pages with parent='/'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section landing pages (with
parent: '/') were showing prev/next links to unrelated sibling sections. For example, /about/ showed "Publishing Events" as previous and "Calendar Spam" as next.Wraps the prev/next block in
{% unless page.parent == '/' %}to skip it on top-level section indices, which are not sequential reading content.